Clean JS code

JS files (pages, components, classes ...) in the src folder are polluted by wrong practices. They need to be cleaned up.

To ensure a global formating on project files, we need to add a formatter tool. Prettier is great for this, and can be set as pre-commit hooks. It forces formatting with the same standard whenever a commit is added to the project. This allows to correct mistakes, thus creating a cleaner repository. Don't forget to verify conflicts with eslint and document this in the Contribution guide or README.md file.

To-do's:

• Add Prettier, Eslint, Husky packages as devDependencies
• Add scripts in package.json to lint and format code in src folder
• Add a configuration object in package.json for Eslint (with Airbnb base)
• Add a configuration object in package.json for Husky
• Add a configuration object in package.json for Prettier
• Document what this does in README.md
• Format src folder
  • Remove blank lines
  • Remove useless imports
  • Remove useless variables
• Clean src folder
  • Remove useless console.log
  • Convert wrong variables (var to const or let)
  • Correct wrong imports (require instead of import from)
  • Create global functions in Utils.js for re-used things (ex: url building from env variables like loginUrl)

added Frontend Priority: high labels

changed the description

assigned to @remi.bisson

created branch 52-clean-js-code to address this issue

mentioned in merge request !6 (merged)

changed the description

added Devops Documentation labels

changed the description

marked the checklist item Add Prettier, Eslint, Husky packages as devDependencies as completed

marked the checklist item Add scripts in package.json to lint and format code in src folder as completed

marked the checklist item Add a configuration object in package.json for Eslint (with Airbnb base) as completed

marked the checklist item Add a configuration object in package.json for Husky as completed

marked the checklist item Add a configuration object in package.json for Prettier as completed

changed the description

marked the checklist item Format src folder as completed

marked the checklist item Remove blank lines as completed

marked the checklist item Remove useless imports as completed

marked the checklist item Remove useless console.log as completed

changed the description

marked the checklist item Convert wrong variables (var to const or let) as completed

marked the checklist item Correct wrong imports (require instead of import from) as completed

marked the checklist item Create global functions in Utils.js for re-used things (ex: url building from env variables like loginUrl) as completed

marked the checklist item Clean src folder as completed

marked the checklist item Document what this does in README.md as completed

mentioned in merge request !7 (merged)

closed with merge request !7 (merged)